Skip to content

Dotenv dependency #23715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Seb33300 opened this issue Mar 27, 2018 · 5 comments
Closed

Dotenv dependency #23715

Seb33300 opened this issue Mar 27, 2018 · 5 comments

Comments

@Seb33300
Copy link

Symfony now provide a Dotenv component.

Since Laravel is already using multiple Symfony components, maybe the vlucas/phpdotenv dependency could be replaced by the Symfony component?
@mfn
Copy link
Contributor

mfn commented Mar 27, 2018

A technical case should be done as to "why", not just "because".

@martinbean
Copy link
Contributor

@Seb33300 What advantages would switching to Symfony’s package provide over keeping the existing package?

@Seb33300
Copy link
Author

I proposed this idea because I thought it could give more consistency to use dependencies from the same vendor.
I not able to tell you if there are a technical advantage to made the change.

Symfony didn't provide this component when vlucas/phpdotenv was added to the Laravel project, and I think this is why the Symfony component isn't used in Laravel at this time.

@Seb33300
Copy link
Author

Fabien explained why he decided to create his own component instead of using vlucas/phpdotenv in this pull request: symfony/symfony#21234

@tillkruss
Copy link
Contributor

Please move this discussion to internals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mfn @martinbean @tillkruss @Seb33300