[5.1] Fixes issue #10403: empty() over Request returns inconsistent results because __isset() is not defined. #10446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…results because __isset() is not defined;
|
That test and data provider is mega hard to read. Is it possible to just create the requests inline and test the values without going throuhg all that data provider business with tons of values? |
|
It was the initial idea. But if first test fail, the next one will not be executed. I don't know if it is a problem, on really. In all case, I'll inline that. Thanks. |
|
Done. |
taylorotwell
added a commit
that referenced
this pull request
Oct 1, 2015
[5.1] Fixes issue #10403: empty() over Request returns inconsistent results because __isset() is not defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was started originally by @kneipp, continuing from PR #10431 and PR #10437 about issue #10403.
It'll add the
__isset()method toHttp\Request, making possible check if property isempty()orisset()correctly.@GrahamCampbell