Skip to content

[5.2] Let use custom Application in Composer scripts #12835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[5.2] Let use custom Application in Composer scripts #12835

wants to merge 3 commits into from

Conversation

vlakoff
Copy link
Contributor

@vlakoff vlakoff commented Mar 23, 2016

Allow to use custom Application by extending ComposerScripts::createApplication and using the extended ComposerScripts class in composer.json.

@GrahamCampbell GrahamCampbell changed the title [5.1 STS] Let use custom Application in Composer scripts [5.1] Let use custom Application in Composer scripts Mar 23, 2016
@GrahamCampbell GrahamCampbell changed the title [5.1] Let use custom Application in Composer scripts [5.2] Let use custom Application in Composer scripts Mar 23, 2016
GrahamCampbell
GrahamCampbell reviewed Mar 23, 2016
View reviewed changes
src/Illuminate/Foundation/ComposerScripts.php
* Creates a Laravel application instance.
*
* @param string $basePath
* @return \Illuminate\Foundation\Application
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guess this should really be the contract here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated.

@vlakoff
Copy link
Contributor Author

vlakoff commented Mar 24, 2016

Refs #12827 and pings @barryvdh :)

@taylorotwell
Copy link
Member

Just define your own Composer Scripts class in that case.

@vlakoff
Copy link
Contributor Author

vlakoff commented Mar 24, 2016

Maybe at least change clearCompiled visibility to protected?

@crynobone
Copy link
Member

Just define your own Composer Scripts class in that case.

Agreed with @vlakoff, having private static function clearCompiled() would mean any project extending the default Illuminate\Foundation\Application need to write separate implementation of Composer Scripts instead of extending Illuminate\Foundation\ComposerScripts.

screen shot 2016-03-26 at 3 15 07 pm

@barryvdh
Copy link
Contributor

Then submit a PR and see if it gets accepted.

@crynobone
Copy link
Member

This IS a good PR IMHO.

@barryvdh
Copy link
Contributor

Oh sorry, mixed this with my original PR. This works for me too, but not my call..

@vlakoff vlakoff deleted the composer branch April 8, 2016 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vlakoff @taylorotwell @crynobone @barryvdh @GrahamCampbell