[5.3] Fix sending empty input fields as null inputs when running tests #15691
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a filter to get only the file inputs called with
this->attach(input, value)
If you are submitting a form that has input file fields and don't attach any file on those inputs
it will send those as normal inputs with a value of null causing a validation exception if any of
those fields have a validation rule of any kind (except required, that will be obvious).
I think there is no use in sending empty file fields as normal inputs with a value of null.
This happens because on how validation of null fields are handled now in 5.3.
If you don't expect those fields to be nullable, you'll have to add the 'nullable' validation rule to
make your test pass.
This filter prevents sending empty input file fields as normal inputs with a null value.
File inputs in an html form...
Test submitting the form...
Inspecting the input within the controller with
dd($request->all())
...