[5.3] Add auth redirect path generation method #16896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation added. |
|
This new feature broke my |
|
FYI, here my workaround: //...
class LoginController extends Controller
{
//...
/**
* Get the post register / login redirect path.
* And keep Efficiently\JqueryLaravel\ControllerAdditions::redirectTo()
*
* @see https://github.com/efficiently/jquery-laravel/issues/1
* @return string
*/
public function redirectPath()
{
if (method_exists($this, 'redirectUserTo')) {
return $this->redirectUserTo();
}
return property_exists($this, 'redirectTo') ? $this->redirectTo : '/home';
}
}So my |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds call of
redirectTomethod inIlluminate\Foundation\Auth\RedirectsUserstrait.It's pretty same as property
$this->redirectTo, but if we will have method - there would be an ability to write custom redirect logic after authentication, registration or password reset. For example we can resolve where user should be redirected by using retrieved data from user data, session, cookies, etc...If there is no
redirectTo()method exists in your controller -redirectToproperty will be used.I thought about name of the method. Just left same as property. Another one was:
resolveRedirectTo().