Fix insert not using $primaryKey on Postgres #244
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed this manually as there was a unit test that also needed to be updated. |
joelharkes
pushed a commit
to joelharkes/framework_old
that referenced
this pull request
Mar 7, 2019
dbpolito
pushed a commit
to dbpolito/framework
that referenced
this pull request
Oct 1, 2019
Remove double config call
gonzalom
pushed a commit
to Hydrane/tmp-laravel-framework
that referenced
this pull request
Oct 12, 2023
Set DB_CONNECTION env variable to Queue failed default database
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just pass the name of the key as a second parameter to insertGetId(). The function already knows how to use it, the key was just not passed to it so it was defaulting to "id".
For example:
INSERT INTO questions ... RETURNING id
Becomes:
INSERT INTO questions ... RETURNING question_id