Skip to content

[6.x] Consistently format factory stub #30991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[6.x] Consistently format factory stub #30991

wants to merge 1 commit into from

Conversation

zepfietje
Copy link
Contributor

This pull request formats the docblock in the factory stub in the same way as in the UserFactory already present in a new Laravel project.

Related to laravel/laravel#5006.

@GrahamCampbell
Copy link
Member

Thanks for the PR, but actually that was a bug in StyleCI.

@GrahamCampbell
Copy link
Member

It was actually patched in production about 11 hours ago. ;)

@GrahamCampbell
Copy link
Member

I've reverted the bad fix on laravel/laravel: laravel/laravel#5196.

@zepfietje
Copy link
Contributor Author

Alright, now I see it was indeed fixed on the develop branch.

@GrahamCampbell
Copy link
Member

GrahamCampbell commented Dec 31, 2019

Not actually fixed on develop. That code is wrong, since it only has one star at the start of the doc. it is fixed on master though, which will be merged into develop soon.

@zepfietje
Copy link
Contributor Author

Thanks! It is consistent with the stub now.

@zepfietje zepfietje deleted the factory-stub-formatting branch December 31, 2019 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants