Skip to content

[7.x] Refactor setMethods to onlyMethods and addMethods #35478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

soilSpoon
Copy link
Contributor

@soilSpoon soilSpoon commented Dec 3, 2020

MockBuilder::setMethods is soft deprecated as of PHPUnit 9
So I refactor the test.

Please merge #35474 after merging

Reference

sebastianbergmann/phpunit#3687

@soilSpoon soilSpoon closed this Dec 3, 2020
@soilSpoon soilSpoon reopened this Dec 3, 2020
@soilSpoon soilSpoon changed the base branch from 7.x to 6.x December 3, 2020 19:23
@soilSpoon soilSpoon changed the title [7.x] Refactor setMethods to onlyMethods and addMethods [6.x] Refactor setMethods to onlyMethods and addMethods Dec 3, 2020
@soilSpoon soilSpoon force-pushed the featuer/phpunit2 branch 2 times, most recently from 8235de6 to ee52288 Compare December 3, 2020 19:28
@soilSpoon soilSpoon changed the base branch from 6.x to 7.x December 3, 2020 19:28
@soilSpoon soilSpoon changed the title [6.x] Refactor setMethods to onlyMethods and addMethods [7.x] Refactor setMethods to onlyMethods and addMethods Dec 3, 2020
@browner12
Copy link
Contributor

Bug fix support for Laravel 7 ended in October 2020.

https://laravel.com/docs/8.x/releases#support-policy

Also, since this is a deprecation, nothing actually breaks, correct?

@soilSpoon
Copy link
Contributor Author

@browner12 thanks to notify

@soilSpoon soilSpoon closed this Dec 3, 2020
@soilSpoon soilSpoon reopened this Dec 3, 2020
@soilSpoon soilSpoon closed this Dec 3, 2020
@soilSpoon soilSpoon deleted the featuer/phpunit2 branch December 3, 2020 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants