[Proposal] Support multiple paginations in 1 page #3868
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would suggest not making any changes on the Eloquent and query builders. Just have a pageName method on the Paginator. It's a lot of code changes to add the page name all over the place in Eloquent and query builder and I think you shuold just make two calls like: |
|
Do you want me to make those changes for you or are you planning on doing it? |
|
I'll do it tomorrow. Thank you! |
|
@taylorotwell How will |
|
Yes. I think it is impossible until laravel application uses 1 instance of Environment class for all pagers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem description: #164
I sugest passing $pageName in paginate() method.
How to use:
In views:
Using appends() is optional.