Add SES Session Token again to Symfony Mailer #38794
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a model using the `artisan make:model` command, there is no option to create a Policy at the same time. This change adds the `--policy` option to the `make:model` command, and includes it in the `--all` option as well.
Updated to pass CI style guides.
Illuminate\Cache\Repository implements PSR-16's Psr\SimpleCache\CacheInterface via the Illuminate\Contracts\Cache\Repository interface. Let's declare that `illuminate/cache` and `laravel/framework` provide `psr/simple-cache-implementation` so that packages relying on `psr/simple-cache implementation` for a PSR-16 cache can be installed in a Laravel project.
* [8.x] Add `assertExists` testing method * add methods Co-authored-by: Taylor Otwell <taylorotwell@gmail.com>
This reverts commit 11edec3.
This reverts commit b4e3823.
|
And I don't know why the tests are failing 😅😂 |
|
@Jubeki try rebasing with master and they'll pass again. |
|
@Jubeki let's keep the rename to avoid the breaking change |
Co-authored-by: michael-rubel <contact@observer.name>
Co-authored-by: michael-rubel <contact@observer.name>
Co-authored-by: michael-rubel <contact@observer.name>
Co-authored-by: michael-rubel <contact@observer.name>
Co-authored-by: michael-rubel <contact@observer.name>
* Update docblocks from Swift Mailer to Symfony Mailer * Make TransportInterface more specific
|
@Jubeki ow sorry, I should have first rebased the symfony mailer PR and you should have rebased with that 🤦♂️ I've just merged master into symfony-mailer. Can you send this in anew? Sorry for the mess. |
|
Yeah I will do that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
symfony/symfony#42982 was merged into 5.4 of Symfony (still waiting to be merged into 6.0) which adds support for the temporary credentials of AWS.
Because in the ses section of the Laravel mail-config the
session_tokenis namedtokenwe need to rename the config key while passing the options to the SES-Factory.Another option would be to add this to the upgrade guide that the config entry needs to be renamed.
The SesFactory only respects the
session_tokenandregionoption right now therefor I would recommend renaming the token to session_token in the config.@driesvints what is your opinion on that?