[9.x] Allows to remove the server.php file
#40034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I absolutely love this change. Thank you. |
|
I like it 👍 |
|
Is it going to be possible to keep using a custom file? We have made some adjustments to add cache-headers to static files to improve performance of Cypress-tests. Of course, we could run the test server differently, but using the built-in server is very convenient. |
|
@Krisell Yes, you can still keep your customized |
Oh wow I can't believe I didn't see that piece when glancing at the code. Thanks! |
shibafu528
added a commit
to shikorism/tissue
that referenced
this pull request
Jul 16, 2022
shibafu528
added a commit
to shikorism/tissue
that referenced
this pull request
Jul 16, 2022
shibafu528
added a commit
to shikorism/tissue
that referenced
this pull request
Jul 20, 2022
shibafu528
added a commit
to shikorism/tissue
that referenced
this pull request
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
serveartisan command makes use of theserver.phpfile that exists on the root of each Laravel project. This file, it's basically the same since 11 Jan 2013, and never needs to be modified at user-land.So this pull request proposes that we remove the file from the Laravel 9 skeleton (user-land), and move it to the framework itself.
laravel/laravel#5747