Skip to content

[9.x] Add failing tests $request->query() no longer can retrieve array query string #40599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[9.x] Add failing tests $request->query() no longer can retrieve array query string #40599

wants to merge 2 commits into from

Conversation

crynobone
Copy link
Member

@crynobone crynobone commented Jan 25, 2022 •
edited
Loading

Exact same code from #40598 for Laravel 9

1) Illuminate\Tests\Http\HttpRequestTest::testQueryMethod
Symfony\Component\HttpFoundation\Exception\BadRequestException: Input value "user" contains a non-scalar value.

/home/runner/work/framework/framework/vendor/symfony/http-foundation/InputBag.php:37
/home/runner/work/framework/framework/src/Illuminate/Http/Concerns/InteractsWithInput.php:510
/home/runner/work/framework/framework/src/Illuminate/Http/Concerns/InteractsWithInput.php:383
/home/runner/work/framework/framework/tests/Http/HttpRequestTest.php:681

Signed-off-by: Mior Muhammad Zaki crynobone@gmail.com

@crynobone
wip
280bd06 
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@crynobone
wip
7b44702 
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@X-Coder264
Copy link
Contributor

This is due to the following deprecation https://github.com/symfony/symfony/blob/v5.4.2/src/Symfony/Component/HttpFoundation/InputBag.php#L39 (which was added via symfony/symfony#34363)

In order for array parameters to work with Symfony 6 \Illuminate\Http\Concerns\InteractsWithInput::retrieveItem will have to be adjusted from

        if (is_null($key)) {
            return $this->$source->all();
        }

        return $this->$source->get($key, $default);

to

        if (is_null($key)) {
            return $this->$source->all();
        }

        return $this->$source->all()[$key] ?? $default;

@crynobone
Copy link
Member Author

crynobone commented Jan 25, 2022 •
edited
Loading

@X-Coder264 feel free to create a PR. Mine is more just to verify there is a bug and the other test PR to 8.x will be merged to 9.x eventually.

@X-Coder264
Copy link
Contributor

@crynobone Done -> #40609

@crynobone crynobone closed this Jan 25, 2022
@crynobone crynobone deleted the query-with-array branch November 3, 2022 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crynobone @X-Coder264