Fix `count` method return value. #4.1 #4069

Andreyco · 2014-04-07T20:21:01Z

Hi there, I have very simple query

dd($this->borrowings()->count());

Actual output

string(1) "1"

Expected output

int(1)

Happens on 4.1.x, but probably on 4.x versions as well.
Since this, we cannot relly on === comparsion operator, which result into false all the time.
Is this behaviour by design, or just a flaw?

Return number represented as integer instead of string.

taylorotwell · 2014-04-07T21:31:37Z

src/Illuminate/Database/Query/Builder.php

@@ -1586,7 +1586,7 @@ public function exists()
 	 */
 	public function count($column = '*')
 	{
-		return $this->aggregate(__FUNCTION__, array($column));
+		return (int)$this->aggregate(__FUNCTION__, array($column));


Can you put a space in between the cast and the function call?

Andreyco · 2014-04-07T21:37:07Z

I did.

Fix `count` method return value. #4.1

Fix count method return value.

9140b65

Return number represented as integer instead of string.

Andreyco changed the title ~~Fix count method return value.~~ Fix count method return value. #4.1 Apr 7, 2014

taylorotwell reviewed Apr 7, 2014
View reviewed changes

Add space between type-casting operator and return value.

022d18c

taylorotwell added a commit that referenced this pull request Apr 7, 2014

Merge pull request #4069 from Andreyco/4.1

618910c

Fix `count` method return value. #4.1

taylorotwell merged commit 618910c into laravel:4.1 Apr 7, 2014

Andreyco deleted the 4.1 branch April 7, 2014 21:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix `count` method return value. #4.1 #4069

Fix `count` method return value. #4.1 #4069

Andreyco commented Apr 7, 2014

taylorotwell Apr 7, 2014

Andreyco commented Apr 7, 2014

Fix count method return value. #4.1 #4069

Fix count method return value. #4.1 #4069

Conversation

Andreyco commented Apr 7, 2014

taylorotwell Apr 7, 2014

Choose a reason for hiding this comment

Andreyco commented Apr 7, 2014

Fix `count` method return value. #4.1 #4069

Fix `count` method return value. #4.1 #4069