[9.x] Add tests for session JSON serialization #41850
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should the new JSON serialization option be added to the documentation (e.g. here https://laravel.com/docs/9.x/session#configuration) or should the |
|
@Krisell JSON serialization is totally broken for view error bag sharing and should probably be removed. |
|
@taylorotwell I did see your comment here now, and the related issue: laravel/laravel#5796 (comment) Has your suggested solution there been attempted? I think using JSON is preferred for several reasons, as described by you in laravel/laravel#5787 and also for the smaller payload size. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests for the new session JSON serialization option added in Laravel 9 (#40595).
The added tests does not duplicate all test cases for
serialize/unserialize, but they do test both reading and writing to the session.