[11.x] Add limit option to the queue failed command #53827
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is OK but we probably need a more robust solution to this in production cases, either via Horizon or the incoming Nightwatch. This is not going to be that useful when jobs are coming in quite quickly. |
|
No problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find the
php artisan queue:failedvaluable. I can quickly check the latest failed jobs from the terminal.Plus, for projects using NoSQL databases, we have to use the
filedriver to store failed jobs, it would be a bit easier to see the latest failed jobs from the terminal.In development environments, we can have hundreds of failed jobs. This number in staging and production environments could be thousands. This command will retrieve all the failed jobs and go all the way down to the oldest ones. That makes this command mostly unusable.
A simple
limitoption is gonna help. Most of the time we are only interested in a handful of latest failed jobs.I have symlinked this feature branch to a test Laravel project, the results are as below:
Currently I am not skilled enough with DynamoDb to implement the
limitmethod. This could be done later.