[11.x] Fix error handling for uniqueVia() when wrong type is returned #54392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be honest we never actually document returning a string from this method? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR gives better error handling when calling the
uniqueVia()method in case the wrong value is returned from the function.example:
This will throw an exception in
InteractsWithUniqueJobs(#54000)/** * Determine the cache store used by the unique job to acquire locks. * * @param mixed $job * @return string|null */ protected function getUniqueJobCacheStore($job): ?string { return method_exists($job, 'uniqueVia') - ? $job->uniqueVia()->getName() + ? $job->uniqueVia()->getName() //throws here : config('cache.default'); }The following ambiguous error is thrown
This PR provides better error handling
Let me know if this requires a test.