Skip to content

[11.x] Sync skeleton configuration #54762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[11.x] Sync skeleton configuration #54762

wants to merge 1 commit into from

Conversation

crynobone
Copy link
Member

* laravel/laravel#6450
* laravel/laravel#6536

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@Jubeki
Copy link
Contributor

Jubeki commented Feb 24, 2025

@crynobone I think all theses change are breaking ones, because some Laravel 11.x applications may rely on theses behaviours. (Laravelshift for example deletes default files from the skeleton, which would mean the framework behaviour would kick in).

@crynobone
Copy link
Member Author

@Jubeki That's doesn't seem like the right approach. Furthermore, we probably need to be able to sync changes (via GitHub Actions) between multiple skeleton now with the introduction of multiple starter kit.

@Jubeki
Copy link
Contributor

Jubeki commented Feb 24, 2025

@crynobone but changing this still means, that applications, who do not define the value in their app config, fallback to the framework config (which was the intention). Meaning their application could possibly break in a minor version bump.

I also don't think that all values need to be synced completely between the skeleton and the framework. Changes to the defaults in the framework should only be allowed on major versions in my opinion.

@crynobone crynobone closed this Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants