Skip to content

Fix attribute name used on Validator instance within certain rule classes #54845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 28, 2025

Conversation

crynobone
Copy link
Member

No description provided.

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@crynobone crynobone changed the base branch from 12.x to 11.x February 28, 2025 08:37
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@crynobone crynobone changed the title Fix attribute name used on Validator instance within File rule class Fix attribute name used on Validator instance within certain rule classes Feb 28, 2025
crynobone and others added 6 commits February 28, 2025 17:14
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@taylorotwell taylorotwell merged commit a8da712 into 11.x Feb 28, 2025
45 checks passed
@taylorotwell taylorotwell deleted the v-val-array branch February 28, 2025 17:10
crynobone added a commit that referenced this pull request Mar 8, 2025
… rule classes

Backport PR #54845 to Laravel 10

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
taylorotwell pushed a commit that referenced this pull request Mar 10, 2025
… rule classes (#54943)

Backport PR #54845 to Laravel 10

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@macropay-solutions
Copy link

macropay-solutions commented Mar 10, 2025

@crynobone @taylorotwell can this security issue be fixed ALSO in Laravel 8, 9 and 10?
image

Update
We added a retroactive fix into our free lib that works for illuminate/validation 8.0.0 -> 11.44.0

@macropay-solutions
Copy link

Also @crynobone

the return type is wrong here:

    /**
     * Replace each field parameter dot placeholder with dot.
     *
     * @param  string  $value
     * @return string // should be array
     */
    protected function replaceDotPlaceholderInParameters(array $parameters)
    {
        return array_map(function ($field) {
            return str_replace('__dot__'.static::$placeholderHash, '.', $field);
        }, $parameters);
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants