[11.x] Respect custom path for cached views by the AboutCommand
#55179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AboutCommand
|
You might want to add a test to |
alies-dev
commented
Mar 27, 2025
| @@ -40,4 +41,16 @@ public function testItCanDisplayAboutCommandAsJson() | |||
| ], $output['drivers']); | |||
| }); | |||
| } | |||
|
|
|||
| #[WithEnv('VIEW_COMPILED_PATH', __DIR__.'/../../View/templates')] | |||
There was a problem hiding this comment.
I don't really like making this test depend on templates from other tests, but also I'm not sure about adding custom fixtures here as compiled views is the main concern of this about console command. I would be glad if you could help with the testing approach here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible to customize a path to cached view files via config and
VIEW_COMPILED_PATHenv var. ButAboutCommanduses a hardcodedstoragePath('framework/views')path. This PR aims to fix this issue.BTW: it's the only occurrence of the
framework/viewsandframework.viewsin code codebase (except some tests), so, no need to worry about other similar issues.