[12.x] Set job instance on "failed" command instance #55617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6fffe41 to
85ba225
Compare
|
Thanks! |
|
I notice that we have the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the job instance on the command instance created when attempting to call the
failedmethod on a job class. It is fully backwards compatible.I have a job that does some logging to a channel that is only for the job itself. In order to group the messages together, I include the job instance ID in the log context. If something goes wrong, I wanted to log an error by adding a
failedmethod to the job class. However, I could not reference the job instance from within thefailedmethod even though I was using theInteractsWithQueuetrait.