Skip to content

[12.x] Enhance the test coverage for Pipeline::through() #56100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2025
Merged

[12.x] Enhance the test coverage for Pipeline::through() #56100

merged 1 commit into from
Jun 22, 2025

Conversation

azim-kordpour
Copy link
Contributor

@azim-kordpour azim-kordpour commented Jun 22, 2025 •
edited
Loading

Hi,
This PR enhances the test coverage for the Pipeline::through() method to ensure that it overwrites previously set or appended pipes.

$object = new stdClass();
$object->value = 1;

$pipeline
    ->through([MultiplyByTwo::class])  // Would make it 2
    ->pipe([AddFive::class])          // Would make it 7
    ->through([AddFour::class])       // Should reset and make it 5
    ->thenReturn();

@taylorotwell taylorotwell merged commit a44bfd8 into laravel:12.x Jun 22, 2025
62 checks passed
mohammad-fouladgar pushed a commit to mohammad-fouladgar/framework that referenced this pull request Jul 22, 2025
@azim-kordpour @mohammad-fouladgar
Add a test for pipeline through method overwriting previously set and…
ada4d85 
… appended pipes (laravel#56100)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azim-kordpour @taylorotwell