[12.x] Return early on belongs-to-many relationship syncWithoutDetaching method when empty values are given
#56157
+27
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohammad-fouladgar
pushed a commit
to mohammad-fouladgar/framework
that referenced
this pull request
Jul 22, 2025
…hing` method when empty values are given (laravel#56157) * Prevent unnecessary sync when IDs are empty and detaching is false * Add test for sync with empty array and detaching disabled * Test with all empty values * Rearrange precedence of methods * Tweak test * Disable query log after sync test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small change to prevent an unnecessary query from being executed when calling
syncWithoutDetachingwith an empty value or collection (collect(),[], ornull).Without this, we have to check every time to ensure the values are present instead of the framework automatically handling this. Over time, this can reduce a lot of conditions from being created unnecessarily, as well as SQL queries.
Before:
After: