Skip to content

Change to hyphenate prefixes and cookie names #56164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

u01jmg3
Copy link
Contributor

@u01jmg3 u01jmg3 commented Jun 28, 2025

@axlon
Copy link
Contributor

axlon commented Jun 29, 2025

👎 This would be a breaking change for projects that don't define this in their own configs. IMHO framework level config changes should be done on major versions only

@u01jmg3
Copy link
Contributor Author

u01jmg3 commented Jun 29, 2025

Sure, just doing as requested. Initial contribution was changing from Str::slug(..., '_') to Str::snake(...) which wasn't a breaking change.

@donnysim
Copy link
Contributor

The original was changing the boilerplate that does not effect existing apps, this is changing the framework default configs that will if these are not already defined in the env, this resulting in a huge breaking change especially for the cookie change. There's 0% this will go through without issues.

@u01jmg3
Copy link
Contributor Author

u01jmg3 commented Jun 29, 2025

I guess they'll have to be left out of sync then and updated later on.

@u01jmg3 u01jmg3 closed this Jun 29, 2025
@u01jmg3
Copy link
Contributor Author

u01jmg3 commented Jun 29, 2025

@axlon, @donnysim - retarget to master or not worth it?

@AhmedAlaa4611
Copy link
Contributor

I think we need to target the master branch.

@axlon
Copy link
Contributor

axlon commented Jun 29, 2025

@axlon, @donnysim - retarget to master or not worth it?

I haven't read up on why this change is being made, but if it is the default on the boilerplate now it probably makes sense to PR it to master here (and should be added to the upgrade guide for 13.x)

@u01jmg3
Copy link
Contributor Author

u01jmg3 commented Jun 29, 2025

Super - we got there in the end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants