Skip to content

Add int to allowed types of value in DatabaseRule #56199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 2, 2025
Merged

Add int to allowed types of value in DatabaseRule #56199

merged 2 commits into from
Jul 2, 2025

Conversation

vkarchevskyi
Copy link
Contributor

Add int to allowed types of $value argument for whereNot method in DatabaseRule.

Right now it allows only string, which is incorrect. PHPStan reports this as error, but the validation works as expected.

Code snippet with example:

fn (Unique $rule): Unique => $rule
    ->whereNot('morph_id', $record->id)
    ->whereNot('morph_type', $record->getMorphClass())

@taylorotwell taylorotwell merged commit 92463ff into laravel:12.x Jul 2, 2025
62 checks passed
mohammad-fouladgar pushed a commit to mohammad-fouladgar/framework that referenced this pull request Jul 22, 2025
@vkarchevskyi @mohammad-fouladgar
fix(rule): add int to allowed type of argument in DatabaseRule.php (l…
c4d847d 
…aravel#56199)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vkarchevskyi @taylorotwell