[12.x] Fix Possible Undefined Variables #56287
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is no tests to show anything was fixed? |
Mea culpa! Of course. 🤦 I'll open a new PR with tests if that's ok. |
|
@taylorotwell, although @calfc is willing to work on a new PR to add tests, one can easily reproduce it: <?php
use Illuminate\Http\Client\PendingRequest;
use Illuminate\Support\Facades\Artisan;
Artisan::command('local:test', function () {
$request = new PendingRequest(); // $factory property is null by default
$this->info($request->get('https://example.invalid/')->body());
});$ php artisan local:test
ErrorException
Undefined variable $request
at vendor/laravel/framework/src/Illuminate/Http/Client/PendingRequest.php:1579
1575▕ $this->factory?->recordRequestResponsePair(
1576▕ $request = new Request($e->getRequest()), null
1577▕ );
1578▕
➜ 1579▕ $this->dispatchConnectionFailedEvent($request, $exception);
1580▕
1581▕ throw $exception;
1582▕ }
1583▕
+5 vendor frames
6 routes/console.php:9
Illuminate\Http\Client\PendingRequest::get()
+13 vendor frames
20 artisan:16
Illuminate\Foundation\Application::handleCommand()
|
|
Hey @rodrigopedra here is the updated PR with tests: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few minor bugs resulting from the use of inline variable assignment within nullsafe method chains in
PendingRequest.phpclass. When$this->factoryisnull, the inline assignment never occurs, leading to variable undefined errors.This PR moves the assignment of these variables outside of the factory call to ensure that they are always defined, regardless of whether
$this->factoryisnull.