Skip to content

[12.x] Add missing PHPDoc type in JoinClause #56378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025

Conversation

FeBe95
Copy link
Contributor

@FeBe95 FeBe95 commented Jul 22, 2025

This PR adds a missing PHPDoc type to the $table property of the JoinClause class.

The $table property will be of type Illuminate\Database\Query\Expression when DB::table()->joinSub() is called. Stack trace:

  1. function joinSub():
    return $this->join(new Expression($expression), $first, $operator, $second, $type, $where);
  2. function join():
    $join = $this->newJoinClause($this, $type, $table);
  3. function newJoinClause():
    return new JoinClause($parentQuery, $type, $table);
  4. function __construct():

@taylorotwell taylorotwell merged commit 5d777bd into laravel:12.x Jul 22, 2025
62 checks passed
@FeBe95 FeBe95 deleted the join-clause-table-phpdoc branch August 1, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants