Trim whitespace when validating required arguments in console commands #56427
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve Validation for Required Console Arguments
Overview
This update enhances the behavior of Artisan commands when prompting for missing required arguments. It ensures that input values consisting solely of whitespace (e.g.
" "
) are treated as empty, prompting the user again instead of accepting an invalid value.Problem
Previously, when prompting for a required argument, the validation logic used:
This means that if a user entered only spaces, the input would pass validation because empty(" ") is false. As a result, commands could proceed with meaningless argument values.
Solution
The validation was updated to use trim() before checking for emptiness:
This ensures that inputs like " " are treated as empty and the user is prompted again with a proper message.
Example
Before
After