Skip to content

[12.x] Clean up redundant PHPDoc #56430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2025

Conversation

AhmedAlaa4611
Copy link
Contributor

Description

Clean up PHPDoc by removing redundant @param tags already covered by type hints.

Copy link
Member

@GrahamCampbell GrahamCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We typically duplicate the phpdoc always.

@AhmedAlaa4611
Copy link
Contributor Author

Hello @GrahamCampbell

I see that we remove it in this PR: #56398

line: 312 and 458

@taylorotwell taylorotwell merged commit 888d3af into laravel:12.x Jul 26, 2025
62 checks passed
taylorotwell added a commit that referenced this pull request Jul 26, 2025
taylorotwell added a commit that referenced this pull request Jul 26, 2025
@GrahamCampbell
Copy link
Member

This PR was reverted, and bad change in the other PR also reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants