Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

@peterfox Hi, would you like to help me review this PR when you are free?

Can you not just use numeric:strict and integer rules together to get what you need?

Thank you very much for your review.

Can you not just use numeric:strict and integer rules together to get what you need?

I think numeric:strict|integer cannot help me solve my problems. Let me give you an example:

1. The 1.0 can pass the numeric:strict|integer validation.

        $v = new Validator($trans, ['foo' => 1.0], ['foo' => 'numeric:strict|integer'])->passes()); // pass
        $v = new Validator($trans, ['foo' => 1.0], ['foo' => 'integer:strict'])->passes()); // fail

2. The 1.0 that passes the validation still results in a TypeError

function test1(int $num): void {}
test1(1.0); // Throw type error here

Other consideration

• integer:strict is clearer and more intuitive, which can:
  • express the intention clearly
  • reduce typing and cognitive load
• numeric:strict|integer is more complex, which results:
  • Developers must understand more edge cases to use them correctly.
  • It may lead to bugs if you forget to add numeric:strict
  • Requires understanding two separate validation rules instead of one

If you have any questions, please let me know. I will try my best to find a good way with you to resolve this problem.