[12.x] Allow creating additional components when model already exists #56513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running `make:model` for an existing model, prompt the user to create additional components (migration, factory, etc.) instead of failing with an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
make:model Conferenceand forgetting flags like-mf, the command fails if the model already exists. This forces developers to either manually create missing components manually or use the--forceflag which will delete existing implementations inside the model (or delete the model and start over).Suggestion
Instead of failing, prompt the user to create additional components using the same interactive multiselect interface available when running
make:modelwithout parameters.Example
Before
After
I've also added a test to the best of my knowledge.
I think this improves the DX by allowing to add forgotten components without starting over. (I run into this on a regular basis. 😅)