[12.x] Normalize file path separators in make:migration command on Windows
#56591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaedrich
reviewed
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds path normalization to the
make:migrationcommand by replacing forward slashes with backslashes on Windows.Why?
Currently, the
make:migrationcommand in Laravel generates migration file paths using mixed directory separators on Windows systems.This differs from other
make:commands that extend thesrc/Illuminate/Console/GeneratorCommand.phpclass, which normalize paths by replacing forward slashes with backslashes on Windows:https://github.com/laravel/framework/blob/12.x/src/Illuminate/Console/GeneratorCommand.php#L189
Changes
Before:
After: