[12.x] Remove unnecessary return in ddBody for consistency #56759
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In PR #56621, the implementation was updated to use a
return
with a ternary:Since both
dd()
andddJson()
terminate the script, the return here is effectively unreachable. This makes the code look like it returns a value, when in reality it never does.A clearer approach, and one that aligns with the original implementation’s style (just without the
function_exists
guard), would be:This keeps the semantics consistent with the
@return never
contract and with otherdd*
helpers in the framework.