[12.x] Fix event helper #56773
Merged
[12.x] Fix event helper #56773
+11
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
browner12
added a commit
to browner12/framework
that referenced
this pull request
Aug 26, 2025
this fully reverts the change from laravel#56684 that was partially reverted in laravel#56773 by adding back the `@return` docblock. clearly this docblock isn't the whole story, but I think it's good to have it back until we fully figure out what the accurate answer is here.
taylorotwell
pushed a commit
that referenced
this pull request
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the return type added in #56684 and adds a test that would have flagged this issue in the first place.
Fixes #56771