[12.x] Refactor duplicated logic in ReplacesAttributes #56787
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closed by mistake and then reopened. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors several validation message replacer methods that shared the same logic:
Instead of duplicating the same code, these methods now delegate to the existing
replaceIn()implementation.This follows the same approach already used in
replaceNotIn(), where the logic is centralized in one method and other similar methods simply call it.framework/src/Illuminate/Validation/Concerns/ReplacesAttributes.php
Lines 309 to 312 in aa671fd
This change reduces code duplication and makes the code easier to maintain.