github action make checkout option persist-credentials explicit #56826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ci seem to be currently failing on l12 branch instead of the change made here. Currently waiting to sync fork to confirm its not from my change |
|
CI/CD is passing now , i'll open back this PR . |
crynobone
reviewed
Sep 2, 2025
| @@ -134,6 +134,7 @@ jobs: | |||
| - name: Checkout code | |||
| uses: actions/checkout@v4 | |||
There was a problem hiding this comment.
@crynobone I fixed it. I reverted and added it back normally.
When CI failed at first, I thought it might be from actions/upload-artifact, but it was actually the L12 branch
This reverts commit b0e8a2d.
godartm
commented
Sep 2, 2025
This reverts commit e27d6bb.
|
I think it's fine to leave this as-is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
The goal of this PR is to make the use of the
persist-credentialsoption in theactions/checkoutaction explicit.By default,
actions/checkoutpersists a credential in the checked-out repo’s.git/config, allowing subsequent Git operations to be authenticated.However, this behavior can be problematic:
.git/configpublicly, e.g. by uploading it as part of an artifact viaactions/upload-artifact..git/configis not ideal unless explicitly required.Unless Git operations are needed in later steps,
actions/checkoutshould be used with:Impact
This change only affects the CI/CD workflows and has no impact on end users.
Testing
To validate this change, the CI pipeline must pass across all impacted workflows.
If preferred, I can split this into multiple PRs for easier review and merging.
I can also begin applying this change to other Laravel repositories before proposing it directly to the framework.
Best,