[12.x] Allow enums on model connection property and methods #56896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnoordsij
commented
Sep 3, 2025
| * @return static | ||
| */ | ||
| public function connection(string $connection) |
There was a problem hiding this comment.
Technically this is backwards incompatible change for classes extending this class and overriding this method with a typed signature, as they would have to update theirs. I'm not sure if such cases are considered to be breaking changes; if so I can port just this change to master if preferred.
cff647b to
3504ed6
Compare
3504ed6 to
345aaa6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up to #56878 and #56271, this PR updates the
Modelclass (andFactoryclass) to allow passing enums for identifying connections there as well. This would allow using the same enum consistently throughout ones codebase.