Fixes the problem with macros returning Renderable implementations #7980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This really is not a solution, rather a workaround for a very specific case (thus not eliminating the problem in all cases) and also a breaking change for people using macros to return views, and then continuing to manipulate that view. |
|
@JoostK hmmm, good points. So I guess then we just have to wait for __toString to be removed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per this previous PR: #7965
The issue is around macros that return view components - resulting in (possibly) exceptions being thrown when the view is rendered via __toString. This ensures that if a macroable class implements a macro that returns a view, it will be rendered correctly and the exception handling work as expected - and everyone's happy!