Add Routing Wildcard '(:all)' to Documentation #1132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm, that is pretty redundant... |
|
That being said, I didn't get until that PR that you could actually write any regex in there. I'm ashamed. |
|
It's not redundant, because (:all) includes all characters, most importantly slashes – as opposed to (:any), which only returns a segment. I found this very useful to protect a folder, though there surely are other use cases. Route::get('files/(:all)', array('before' => 'auth', function($path)
{
$path = path('storage') . 'files/' . $path;
if (File::exists($path))
{
return Response::download($path, 'smth');
}
return Response::error('404');
}));With (:any), the Route would have to look something like this: Route::get('files/(:any)/(:any?)/(:any?)', array('before' => 'auth', function($param1, $param2=null, $param3=null)
{
$path = path('storage') . 'files/' . $param1 . '/' . $param2 . '/' . $param3;
... |
taylorotwell
added a commit
that referenced
this pull request
Sep 2, 2012
Add Routing Wildcard '(:all)' to Documentation
zoe-edwards
pushed a commit
to zoe-edwards/laravel
that referenced
this pull request
Oct 14, 2013
…d-depth Find autoload files for packages that aren't in a vendor/package directory structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found an (:all) selector in the source, might be worth adding.
http://laravel.com/api/source-class-Laravel.Routing.Router.html#79