Fix insert() method for related models. #1143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
1 similar comment
|
+1 |
|
There is a behavior change here. One path returns ->save() which is a boolean, and other returns ->create() with is a model instance. A model instance should always be returned to not break expected functionality. |
|
@taylorotwell So what do you suggest, how to save objects in this scenario then? |
|
@taylorotwell Fixed. This wasn't properly documented in the method's PHPDoc, either. It returned (Right now, there'd be other return values in case the passed model already existed in the database. But then, you're not supposed to use |
taylorotwell
added a commit
that referenced
this pull request
Sep 2, 2012
Fix insert() method for related models.
|
Thanks! |
zoe-edwards
pushed a commit
to zoe-edwards/laravel
that referenced
this pull request
Oct 14, 2013
Fixes #1141
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in this forum topic, passing a model object to a relationship's
insert()method caused problems, if custom attribute setters were specified.The reason for this is that the model wasn't filled with the raw attribute data. Instead, every attribute's value was passed to the attribute's setter method (if it existed), causing e.g. duplicate hashing of passwords.
In fact, the copying of the attributes of the model object passed to
insert()to an entirely new object is completely unnecessary. Instead, we can simply set the foreign key and then save the model directly.