Fixed a problem with Eloquent::get_dirty
#1201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you had a synched Eloquent model (e.g. without changed values) but one of those values is `null`, then that value would be considered as dirty. `Eloquent::changed` returns false, but the value is present in `Eloquent::get_dirty`. This fix makes sure that a `null` value in `$attributes` is only present in `get_dirty` when it wasn't at all *set* in `$original`.
|
Indeed. I had already fixed this in pull request #901, but Taylor reverted a little bit too much in v3.2.5. :) |
|
I remember having seen that pull request before, but didn't think of it when I just experienced the problem. Here's the revert: 1203473 |
|
I'll spend the evening (I live in The Netherlands) writing some Eloquent unit tests to avoid these issues |
Basic Eloquent unit tests. Lacks database operations, relationship testing and some magic method calls.
|
Thanks! |
taylorotwell
added a commit
that referenced
this pull request
Sep 26, 2012
Fixed a problem with `Eloquent::get_dirty`
|
It seems the problem was fixed not completely. If some tinyint DB field has NULL as default value and then it has been changed to 0 then Model::get_dirty() doesn't consider that as a change. It thinks that null == 0 and the change isn't saved by Model::save(). |
|
I guess you're right that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you had a synched Eloquent model (e.g. without changed values) but
one of those values is
null, then that value would be considered asdirty.
Eloquent::changedreturns false, but the value is present inEloquent::get_dirty.This fix makes sure that a
nullvalue in$attributesis onlypresent in
get_dirtywhen it wasn't at all set in$original.