Skip to content

Added PDO error code #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 5, 2013
Merged

Added PDO error code #1221

merged 2 commits into from
Jan 5, 2013

Conversation

arisk
Copy link
Contributor

@arisk arisk commented Sep 14, 2012

Addition to make recovering from a PDOException easier.

@franzliedke
Copy link
Contributor

Couldn't you just overwrite getCode() instead? Or determine the code when the inner exception is passed to the outer one - probably in the constructor!?

@arisk
Copy link
Contributor Author

arisk commented Sep 14, 2012

@franzliedke getCode is a final method. Sure, I'll add it in the constructor instead.

@franzliedke
Copy link
Contributor

Ah, true, forgot that. Thanks for the heads-up and the change.

@arisk
Copy link
Contributor Author

arisk commented Sep 14, 2012

Sure thing!

taylorotwell added a commit that referenced this pull request Jan 5, 2013
@taylorotwell taylorotwell merged commit c397c26 into laravel:develop Jan 5, 2013
@taylorotwell
Copy link
Member

Thanks

zoe-edwards pushed a commit to zoe-edwards/laravel that referenced this pull request Oct 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants