Skip to content

Correct broken links in docs #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2012
Merged

Correct broken links in docs #1236

merged 2 commits into from
Sep 26, 2012

Conversation

kuroi
Copy link

@kuroi kuroi commented Sep 18, 2012

No description provided.

@franzliedke
Copy link
Contributor

Does that really fix it? Shouldn't you just add a slash at the beginning of the links?

@kuroi
Copy link
Author

kuroi commented Sep 18, 2012

Now that was embarrassing. Thanks for the gentle nudge Franz.

@Jakobud
Copy link
Contributor

Jakobud commented Sep 18, 2012

Weird I could have sworn there were pull requests a month ago to fix these.

@franzliedke
Copy link
Contributor

Those were in the menu.

@Kindari
Copy link
Contributor

Kindari commented Sep 19, 2012

I disagree with just prepending "/" to these links. On installations where laravel is not in the document root these links will not work. Although, since this is likely a problem in more then just these files it should be addressed on a seperate pull request.

@kuroi
Copy link
Author

kuroi commented Sep 19, 2012

As the documents are in markdown format, that's really the only option. It won't cause problems for sites where laravel isn't in the root though, as the docs bundle that comes as part of the core package contains a route that sends docs pages to the documentation folder, provided its location relative to the main laravel folder hasn't been changed.

@Jakobud
Copy link
Contributor

Jakobud commented Sep 20, 2012

All the links in the documentation have a / prepended to their URI's. So this pull request is consistent with the rest of the doc's.

taylorotwell added a commit that referenced this pull request Sep 26, 2012
Correct broken links in docs
@taylorotwell taylorotwell merged commit 439f9c8 into laravel:master Sep 26, 2012
zoe-edwards pushed a commit to zoe-edwards/laravel that referenced this pull request Oct 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants