Auth token now nulled on logout #1255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joel Marcotte <skaner@gmail.com>
taylorotwell
added a commit
that referenced
this pull request
Sep 26, 2012
Auth token now nulled on logout
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the token is not nulled on logout, a (poor) path going like this would work (incorrectly) :
Auth::attempt($data); // Successful login
...
Auth::logout(); // Successful logout
...
Auth::check(); // -> True!
Originally noticed this behavior in a test on a custom auth backend.
Also modified the appropriate test case to reflect this modification (this behavior was hidden due to an added workaround in the test cases).
Signed-off-by: Joel Marcotte <skaner // @gmail.com>