Update LaravelRequest.php to alllow PUT/DELETE/PATCH on PHP5.4 built-in server #1384
Conversation
….php This will allow the built in PHP 5.4 server to interpret PUT, DELETE, and PATCH content. It uses the HTTP_CONTENT_TYPE variable instead of CONTENT_TYPE; Symfony hasn't adapted for this yet.
|
Mmmm pull. |
Update LaravelRequest.php to alllow PUT/DELETE/PATCH on PHP5.4 built-in server
|
Shouldn't that pull request go straight to Symfony, @machuga ? |
|
Wait, that was a stupid comment, wasn't it? Looks like this is a Laravel file. But why is it in the Symfony directory? |
|
@franzliedke It's separate for some slight changes. I'm going to send the same patch to symfony proper as well and see what they think. |
| @@ -13,7 +13,8 @@ static public function createFromGlobals() | |||
| { | |||
| $request = new static($_GET, $_POST, array(), $_COOKIE, $_FILES, $_SERVER); | |||
|
|
|||
| if (0 === strpos($request->server->get('CONTENT_TYPE'), 'application/x-www-form-urlencoded') | |||
| if ((0 === strpos($request->server->get('CONTENT_TYPE'), 'application/x-www-form-urlencoded') | |||
| || (0 === strpos($request->server->get('HTTP_CONTENT_TYPE'), 'application/x-www-form-urlencoded'))) | |||
There was a problem hiding this comment.
FYI it's more consistent with the rest of the Laravel code to use "or" instead of "||"
There was a problem hiding this comment.
@Jakobud Indeed, it's normally preferred - however this is a file derived from a Symfony file - in the rest of the Symfony Request object they use '||'. Additionally, '&&' is also used in the same conditional - jumbling up '&&' with 'or' would be pretty weird.
…ion-test Fixed failing unit test for SQL Server Connector
This will allow the built in PHP 5.4 server to interpret PUT, DELETE, and PATCH content.
It uses the HTTP_CONTENT_TYPE variable instead of CONTENT_TYPE. Symfony hasn't adapted for this yet.