Skip to content

Conversation

toszcze
Copy link
Contributor

@toszcze toszcze commented Jun 18, 2011

No description provided.

@taylorotwell
Copy link
Member

Wow, thanks a lot! This looks great! I've not used APC caching before, would it be helpful to prepend a string to the key so items written to the cache by other applications on the same server are not overwritten? The Memcache cache driver does this. Like I said, I'm not sure if this is necessary, but just thought I would check!

@toszcze
Copy link
Contributor Author

toszcze commented Jun 18, 2011

I don't think it's necessary, because the APC isn't shared between applications.

@taylorotwell
Copy link
Member

Hmm, check out this from the manual: http://www.php.net/manual/en/ref.apc.php#76772

I think two applications on the same physical machine would share APC caches, similar to Memcached.

@toszcze
Copy link
Contributor Author

toszcze commented Jun 18, 2011

Yes, you're right. I've added the cache key to avoid collisions.

@taylorotwell
Copy link
Member

Great, thanks for your work on this! I really appreciate it. I'll merge this in tonight!

On Jun 18, 2011, at 5:14 PM, toszczereply@reply.github.com wrote:

Yes, you're right. I've added the cache key to avoid collisions.

Reply to this email directly or view it on GitHub:
https://github.com/taylorotwell/laravel/pull/15#issuecomment-1394766

@toszcze
Copy link
Contributor Author

toszcze commented Jun 18, 2011

It's not a big deal. It's a very small addition, which I've made for myself and I've thought it could be useful for someone else.

taylorotwell added a commit that referenced this pull request Jun 19, 2011
Added APC cache driver.
@taylorotwell taylorotwell merged commit ab3be56 into laravel:develop Jun 19, 2011
dinhtancg referenced this pull request in traixinhgaidep/laravel Apr 19, 2018
drewmw5 pushed a commit to drewmw5/laravel that referenced this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants