Skip to content

Make artisan executable. #1597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Make artisan executable. #1597

wants to merge 1 commit into from

Conversation

cmenke
Copy link

@cmenke cmenke commented Jan 14, 2013

Put the Hashbang to use, so we can run ./artisan <command> on new projects without changing file permissions first.

Put the Hashbang to use.
@iryw
Copy link

iryw commented Jan 14, 2013

I fill like this should be done by the user of the framework.

@Jakobud
Copy link
Contributor

Jakobud commented Jan 14, 2013

I remember submitting a pull request to add in the hashbang last summer and it was put in. But at some point in the past few months Taylor removed it for some reason.

Added in 3.2.3
https://github.com/laravel/laravel/blob/v3.2.3/artisan

Removed in 3.2.11
https://github.com/laravel/laravel/blob/v3.2.11/artisan

@cmenke
Copy link
Author

cmenke commented Jan 15, 2013

@iryw I don't see any disadvantages providing the functionality by default (like composer does, too). Especially, since the Hashbang is implemented in the code already. It offers another – IMO more convenient – option. Anyone prefering to use php artisan <command> is of course still free to do so.

@Jakobud this PR is intended for L4, where it's still in place: #!/usr/bin/env php

@Jakobud
Copy link
Contributor

Jakobud commented Jan 15, 2013

I agree, it's nice to have in there. In any case, I'm sure Taylor had a good reason to remove it.

@daylerees
Copy link
Contributor

I added this in myself and Taylor removed it, so he probably has a good reason for doing so.

@cmenke
Copy link
Author

cmenke commented Mar 11, 2013

Understood – I guess I can live with chmodding artisan for new installs 😛

@cmenke cmenke closed this Mar 11, 2013
zoe-edwards pushed a commit to zoe-edwards/laravel that referenced this pull request Oct 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants