Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like $model->save(), $model->push() needs to return success / fail. I ran into this issue because my app was rolling back the transaction when if (!$model->push()) {} occurred, which of course was returning Null.
With this pull request, if the model's ->save() method or any of the child relationship's ->push() method's fail, it'll return false. This of course may leave the DB in a mixed state, so it is up the the user to encapsulate ->push() in a pDO transaction and roll back if ->push() fails.
L3 Example:
DB::connection()->pdo->beginTransaction();
if (!$model->push())
DB::connection()->pdo->rollBack();
else
DB::connection()->pdo->commit();
Does $model->push() exist in L4? If not, it is really nifty to have. Hint Hint.