Skip to content

Conversation

johnnye
Copy link

@johnnye johnnye commented Jul 2, 2011

Moved the class over to bcrypt, as this is a better implementation for storing passwords, it includes a work factor.

There is a lot on the internet urging us all to use bcrypt as we can up the work factor and keep up with Moores law. I might have missed something as I only came across laravel this evening and wanted to use it for an upcoming project.

If I've missed something let me know.

-John

Moved the class over to bcrypt, as this is a better implementation for storing passwords, it includes a work factor.
@pedroborges
Copy link
Contributor

@taylorotwell, I don't if this is the best way to implement a better encryption or not but I'd really like to see bcrypt used to encrypt passwords in Laravel. I just noticed it is built-in PHP 5.3 as crypt(), so it can be implemented without installing bcrypt separately.

Thanks for collaborating @johnnye :)

@taylorotwell
Copy link
Member

Yeah, let me take a look into our options and see what looks best. Also, typically I like to keep pull requests on the develop branch. Thanks for your collaboration. I'll dig into this.

@johnnye
Copy link
Author

johnnye commented Jul 2, 2011

It was 1am my time so probably not the best time to do that coding. I'll redo it on the dev branch, or you can redo the implementation. like @pedroborges said, as its free in PHP 5.3+ good thing to be using it.

@taylorotwell
Copy link
Member

Just want to note that I do have a solution for this and will be integrating the PHPass library used by applications like Wordpress and Drupal into Laravel. This library uses bcrypt and will provide a more secure solution to password hashing in Laravel.

@pedroborges
Copy link
Contributor

Thanks again Taylor!

zoe-edwards pushed a commit to zoe-edwards/laravel that referenced this pull request Oct 14, 2013
Fix path issues for Windows environments.
sl0wik added a commit to sl0wik/laravel that referenced this pull request Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants