Allow developers to set the Content-Disposition header in Response::download() #1970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 on this |
taylorotwell
added a commit
that referenced
this pull request
May 14, 2013
Allow developers to set the Content-Disposition header in Response::download()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows developers to set the Content-Disposition header in Response::download() without it getting overwritten. This was a necessary change for me because I want to be able to suggest to the browser whether or not to display a PDF or to download it with:
Content-Disposition: inline; filename=file.pdf;
or
Content-Disposition: attachment; filename=file.pdf;
This change allows me to do that.