Skip to content

Fix russian translation for 'exists' validation rule #1992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2013

Conversation

neoascetic
Copy link
Contributor

No description provided.

@maciejczyzewski
Copy link

Good change.

taylorotwell added a commit that referenced this pull request May 15, 2013
Fix russian translation for 'exists' validation rule
@taylorotwell taylorotwell merged commit fe00e01 into laravel:master May 15, 2013
@neoascetic neoascetic deleted the patch-1 branch May 15, 2013 21:52
@ericmagnuson
Copy link

My knowledge of Russian isn't native speaker level, but doesn't "не верно" simply mean "not valid"? It seems like the previous translation "уже существует" is more descriptive. Does "не верно" infer that it doesn't exist?

@neoascetic
Copy link
Contributor Author

exist validation rule means that record must exist in given database table. So, when validation fails this means that record does not exist, i. e. specified attribute is invalid, and "already exist" message is absolutely wrong (since this value does not exist at all).
"Already exist" message is more related to unique validation rule (and you can see that messages for both rules are eqivalent in the Russian translation, but not in English one, which is probably copy-paste issue).

@ericmagnuson
Copy link

Oh, my bad! I got my validation rules mixed up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants